Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle

From: Simon Arlott
Date: Sun Jul 15 2007 - 05:53:58 EST


On 15/07/07 09:52, Denis Cheng wrote:
> Signed-off-by: Denis Cheng <crquan@xxxxxxxxx>
> ---
> drivers/net/wireless/wavelan.c | 806 ++++++++++++++++++----------------------
> 1 files changed, 369 insertions(+), 437 deletions(-)

Do people ever check what Lindent does?

> - } else if (base_addr > 0x100) { /* Check a single specified location. */
> + } else if (base_addr > 0x100) { /* Check a single specified location. */

What is Lit doing here?! It's changed "{<space>/*" to "{<tab>/*"...


> - } else { /* Scan all possible addresses of the WaveLAN hardware. */
> + } else { /* Scan all possible addresses of the WaveLAN hardware. */

And again... with two tabs for maximum unreadability. That line is now
90 characters long instead of 75.


> - "%s: <-wavelan_probe()\n",
> - dev->name);
> + "%s: <-wavelan_probe()\n", dev->name);

There are spaces in that line after the tabs...


> -out1:
> + out1:

NAK: A perfectly valid non-indented label is now indented by 6 spaces.


> -out:
> + out:

And again.


> - dev->name, (unsigned int) dev);
> + dev->name, (unsigned int)dev);

Those spaces after the tabs have been ignored...

--
Simon Arlott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/