Re: [GIT PULL][RESEND] KVM Updates for 2.6.23-rc1

From: Linus Torvalds
Date: Sun Jul 15 2007 - 19:44:21 EST




On Sat, 14 Jul 2007, Avi Kivity wrote:
>
> Linus, please do your usual thing from the repository and branch at

It has code like

+ /* Can deadlock when called with interrupts disabled */
+ WARN_ON(irqs_disabled());
+
/* prevent preemption and reschedule on another processor */
int me = get_cpu();

which is against the coding conventions (and shouldn't even compile
cleanly - but maybe we don't have the "warn about C99 variable
declarations" thng on?).

Please don't do that.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/