Re: [patch 1/3] ps3: Disk Storage Driver

From: Jeff Garzik
Date: Tue Jul 24 2007 - 08:38:29 EST


Andy Whitcroft wrote:
Andrew Morton wrote:

+ start_sector = req->sector*priv->blocking_factor;
+ sectors = req->nr_sectors*priv->blocking_factor;
s/*/ * /. checkpatch missed this.

Ok, this is something we need to decide on. Currently we only ask for
consistent spacing on all the mathematic operators. This is mostly as
we do see a large number of non-spaced uses in defines and the like.

I am happy to expand these tests so they are always spaced on both sides
style if that is the preference.

That is most definitely the preference: spaces surround operators.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/