Re: [PATCH] [2/11] x86: Fix alternatives and kprobes to remap write-protected kernel text

From: Mathieu Desnoyers
Date: Tue Jul 24 2007 - 11:20:31 EST


* Jeremy Fitzhardinge (jeremy@xxxxxxxx) wrote:
> Mathieu Desnoyers wrote:
> > Hi Rusty,
> >
> > Good catch. I also still wonder why alternative (except alternative smp,
> > which is ok) and paravirt patching functions are not marked __init. I really
> > hope they are never used when NMI, MCE are enabled or when threads may
> > have been preempted in the site being patched, or it could result in an
> > illegal instruction.
> >
>
> We need to patch modules at load time. Presumably an NMI/MCE handler
> will not depend on code in a being-loaded module.
>
> J
>

Oh yes, I see. That's ok since the code of a being-loaded module is not
executed yet.

Thanks,

Mathieu

--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/