Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports toplatform devices - broke my serial console

[Jeff Garzik]

Bjorn Helgaas wrote:
> On Tuesday 24 July 2007 02:13:49 pm Jeff Garzik wrote:
> > Bjorn Helgaas wrote:
> > >   - Linux enumerates CPUs with the MADT; I think Windows uses the ACPI
> > >     namespace.  Sometimes there are multiple MADTs, and sometimes Linux
> > >     uses the wrong one.
> > Color me skeptical.  I think we would have bug reports if we were really 
> > getting this wrong a lot of the time.
>
> We do have bug reports, like http://bugzilla.kernel.org/show_bug.cgi?id=7465
> Not very many, but enough that I'd like to get to the root cause.
>
> > You seem to be missing that ignoring BIOS is often a VERY GOOD thing, 
> > that has served us well many many times in the past.
>
> I can see that I'm not going to win this argument :-)
>
> But I would like to find and fix the problem with Sebastien's machine,
> because the patch does fix real problems with IRDA and I think the fix
> for Sebastien is likely to fix other PNP issues.

Please go back and fix the original issue!

If you are having problems caused by double-probing, the fix is NOT to 
remove one the probes.  The fix is to ensure use of proper resource 
reservation, and in some cases, add co-driver-awareness.

Your entire justification for the patch has not been proven, since you 
demonstrably have not solved the original bug for which your patch was 
intended to solve.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/