Re: [patch 2.6.23-rc1] dma_free_coherent() needs irqs enabled (sigh)

From: Stefan Richter
Date: Wed Jul 25 2007 - 06:47:18 EST


For linux1394-devel:

David Brownell wrote at LKML:
> On at least ARM (and I'm told MIPS too) dma_free_coherent() has a newish
> call context requirement: unlike its dma_alloc_coherent() sibling, it
> may not be called with IRQs disabled. (This was new behavior on ARM as
> of late 2006, caused by ARM SMP updates.) This little surprise can be
> annoyingly driver-visible.
>
> Since it looks like that restriction won't be removed, this patch changes
> the definition of the API to include that requirement. Also, to help
> catch nonportable drivers, it updates the x86 and swiotlb versions to
> include the relevant warnings. (I already observed that it trips on the
> bus_reset_tasklet of the new firewire_ohci driver.)

Also in ohci_set_config_rom().
--
Stefan Richter
-=====-=-=== -=== ==--=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/