Re: [PATCH][RFC] getting rid of stupid loop in BUG()

From: Jeremy Fitzhardinge
Date: Wed Jul 25 2007 - 13:38:16 EST


Al Viro wrote:
> Who said that we need to populate that section from asm? Define
> a static variable in that section inside a block; identifier is
> not a problem, obviously.
>
> I'm not saying that it's not revolting, but it's not impossible.
>

I tried that, but there's still no way of getting a pointer to the ud2a
instruction in there. gcc just generates garbage if you try to use use
the &&label syntax on a label which isn't (potentially) the target of a
goto (it just gets placed somewhere random).

But there's a bigger problem than that. If the BUG is in code which can
be replicated (ie inlined or unrolled), then it would also require
replicating the static variable...

J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/