Re: [bug] SLUB & freeing locks [was: Re: 2.6.23-rc1: knownregressions with patches]

From: Peter Zijlstra
Date: Thu Jul 26 2007 - 07:11:33 EST


On Thu, 2007-07-26 at 14:08 +0300, Pekka Enberg wrote:
> On 7/26/07, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> > --- linux-2.6.orig/mm/slub.c
> > +++ linux-2.6/mm/slub.c
> > @@ -1656,6 +1656,7 @@ static void __always_inline slab_free(st
> > unsigned long flags;
> >
> > local_irq_save(flags);
> > + debug_check_no_locks_freed(object, s->size);
>
> Although it doesn't matter much, I think this should be s->objsize. Christoph?

Ah, I think you are right, s->size includes all the padding and
redzones.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/