Re: [PATCH] flush icache before set_pte on ia64 take3

From: KAMEZAWA Hiroyuki
Date: Thu Jul 26 2007 - 12:09:21 EST


On Thu, 26 Jul 2007 17:13:52 +0200
Zoltan Menyhart <Zoltan.Menyhart@xxxxxxxx> wrote:

> I can agree:
> - lazy_mmu_prot_update() is not the right place for a flush
> - to flush I-cache before inserting PTE (at least for the
> machines with physical address tagged caches)
>
> Can we have a separate, specific exec_flush_phtag_icache_page()
> that is to be called before inserting a PTE with the exec bit on
> for physical address tagged I-caches) ?
> It is defined in asm-generic/cacheflush.h as NO-OP.
>
> Or exec_flush_icache_page_before_set_pte() ?
>
Thank you for advise. Hmm..how about this ?
==
/*
* synchronize icache and dcache if the hardware doesn't do it automatically
* and the page is executable.
*/
static inline arch_sync_icache_dcache(pte_t pte, page) {

}
==

Anyway, I understand your point. Thanks!

Regards,
- Kame
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/