Re: [PATCH] core_pattern: Add ability for core_pattern to parsearguments when pattern is a pipe

[Andrew Morton]

On Thu, 26 Jul 2007 13:40:19 -0400 Neil Horman <nhorman@xxxxxxxxxxxxx> wrote:

> 	Currently, core dumps can be redirected to a pipe by placing the
> following string template in /proc/sys/kernel/core_pattern:
> |<path/to/application>
> This patch extends this ability, allowing the core_pattern to contain arguments
> to be passed as an argv array to the userspace helper application.  It also add
> a format specifier, %c, which allows the RLIM_CORE value of the crashing
> application to be passed on the command line, since RLIMIT_CORE is reduced to
> zero when execing the userspace helper

This all seems to be getting a bit nutty.  Who needs this feature
and what will they do with it, etc?

You have a few open-coded kstrdup()s in there, btw.  And an open-coded
free_argv_array() on the error path.  And a lot of checkpatch warnings.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/