Re: [PATCH] lockd and nfsd endianness annotation fixes

From: Al Viro
Date: Thu Jul 26 2007 - 21:38:45 EST


On Thu, Jul 26, 2007 at 09:19:22PM -0400, J. Bruce Fields wrote:

> Thanks, uh, I probably saw that message too.
>
> Hm, trying it just now--it catches the svclock.c mistake, but not the
> one in nfsd/nfs4xdr.c--at least not as far as I can tell.

fs/nfsd/nfs4xdr.c:2659:32: warning: incorrect type in argument 2 (different base types)
fs/nfsd/nfs4xdr.c:2659:32: expected int [signed] nfserr
fs/nfsd/nfs4xdr.c:2659:32: got restricted unsigned int [usertype] status

is what got triggered. I.e. call in
case OP_SECINFO:
nfsd4_encode_secinfo(resp, op->status, &op->u.secinfo);
break;
which pointed to the misannotated function...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/