Re: [PATCH] core_pattern: Add ability for core_pattern to parse arguments when pattern is a pipe

[Neil Horman]

On Thu, Jul 26, 2007 at 03:02:19PM -0700, Jeremy Fitzhardinge wrote:
> Neil Horman wrote:
> > +static void free_argv_array(char **argv)
> > +{
> > +	int i;
> > +	if (argv != NULL) {
> > +		for (i = 0; argv[i] != NULL; i++)
> > +			kfree(argv[i]);
> > +		kfree(argv);
> > +	}
> > +
> > +}
> >   
> 
> I've helpfully already provided free_argv() in lib/argv_split.c.
> 
> > +
> > +/*
> > + * format_corename_argv will inspect the corename string, 	
> > + * and for every option found after the binary name
> > + * it will remove the option from the string, and place it
> > + * in the argv array, that can then be passed to the 
> > + * usermodehelper if core_pattern is a pipe
> > + * Assumes that corename is declared on the stack of the caller
> > + */
> > +static char **format_corename_argv(char *corename)
> > +{
> >   
> 
> And it looks like this could be adapted to use argv_split() with a bit
> of additional processing.
> 
>     J
I didn't see these, thanks.  I've got the aforementioned misc cleanup patch to
send for this work to Andrew still, I'll roll these changes in with it.

Regards
Neil


-- 
/***************************************************
 *Neil Horman
 *Software Engineer
 *Red Hat, Inc.
 *nhorman@xxxxxxxxxxxxx
 *gpg keyid: 1024D / 0x92A74FA1
 *http://pgp.mit.edu
 ***************************************************/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/