Re: serial flow control appears broken

From: Lee Howard
Date: Fri Jul 27 2007 - 14:13:15 EST


Maciej W. Rozycki wrote:

The TTY line discipline driver could do that based on the amount of received data present in its buffer. And it should if asked to (a brief look at drivers/char/n_tty.c reveals it does; obviously there may be a bug somewhere though). So could e.g. the SLIP and PPP line discipline drivers, though the criteria might be different (apparently they do not, which is a shame).

The serial drivers have nothing to do about it -- all they can do is pushing data upstream, to the discipline driver. They can provide an interface to hardware flow control features though, if implemented by a given UART.


Thank you for this clarification. So I should have more correctly been saying that "tty flow control appears broken". Right?

I've asked the manufacturer to take a look at drivers/char/n_tty.c to see if they can't see anything obvious.

Thanks,

Lee.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/