Re: [PATCH 2/3] core_pattern: allow passing of arguments to user mode helper when core_pattern is a pipe

From: Neil Horman
Date: Fri Jul 27 2007 - 20:47:30 EST


On Fri, Jul 27, 2007 at 01:54:19PM -0700, Jeremy Fitzhardinge wrote:
> Neil Horman wrote:
> > + int helper_argc = 0;
> >
> > + helper_argv = argv_split(GFP_KERNEL, corename+1, &helper_argc);
> >
>
> Hm, I suspect most users of argv_split don't really care about argc, so
> it would useful to change argv_split to take NULL as the argc pointer,
> rather than declare a bunch of unused variables. Interested in throwing
> a patch together?
>
> J


Gladly, I'll take care of it next week.

Regards
Neil

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/