Re: [PATCH 2/3] core_pattern: allow passing of arguments to usermode helper when core_pattern is a pipe

From: Jeremy Fitzhardinge
Date: Sat Jul 28 2007 - 18:54:18 EST


Neil Horman wrote:
> Jeremy asked that I make a patch next week to address split_argv's requirement
> that the argc parameter be non-NULL. I'll be fixing that next week, and what I
> can do is further enhance it such that it ignores spaces in quoted strings,
> which should address the case that concerns you. I.E I can make split_argv
> behave such that:
> echo "|\"foo bar\" --pid %p" > /proc/sys/kernel/core_pattern
> results in the following argv:
> {{"foo bar"}, {"--pid"}, {"1234"}}
>
> Which I think handles what you are looking for.
>

No, please don't. My original argv_split did that, and it was just way
too complex. If you need complex quoting, you can always point it at a
shell script and handle it there.

J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/