Re: [PATCH] bsg: Fix warning with CONFIG_BLK_DEV_BSG=n

[Jens Axboe]

On Sat, Jul 28 2007, Roland Dreier wrote:
> The current stub definitions of bsg_register_queue() and
> bsg_unregister_queue() as macros leads to
> 
>     drivers/scsi/scsi_sysfs.c: In function 'scsi_sysfs_add_sdev':
>     drivers/scsi/scsi_sysfs.c:718: warning: unused variable 'rq'
> 
> because the first parameter of bsg_register_queue() is completely
> discarded.  As akpm says, "program in C, not in cpp."  We might as
> well get a little bit better type-checking when we fix this by
> converting the stubs to empty inline functions.

James should already have that patch queued for inclusion since last
week.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/