Re: [PATCH] fs/partitions/check.c: add_partition() warning fixes(take 2)

[Cornelia Huck]

On Mon, 30 Jul 2007 17:47:55 +0800,
Eugene Teo <eugeneteo@xxxxxxxxx> wrote:

> +err_out_del_link:
> +	sysfs_remove_link(&p->kobj, "subsystem");
> +err_out_del_kobj:
> +	if (!disk->part_uevent_suppress)
> +		kobject_uevent(&p->kobj, KOBJ_REMOVE);
> +	kobject_put(&p->kobj);
> +err_out:
> +	kfree(p);
>  }

No, this is wrong. You need to move the put behind err_out and remove
the kfree. (The release function will take care of p.)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/