Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

From: Jeff Garzik
Date: Mon Jul 30 2007 - 12:26:42 EST


Seems pretty good to me, save for one minor detail: patches #1/#2 should be combined together for greater git-bisect happiness. Ditto for patches #3/#4. Largely harmless in this case, but keeps the git history pollution to a minimum.

Caveat reviewer: I'm not an expert of net/ipv4/* code, so I reviewed largely from the driver API perspective.

David, thoughts on merging? I'm not We could stick this into your tree or mine. Whether yours or mine, I would like to keep the driver and net-core patches together in the same git tree.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/