Re: [PATCH 2/4][RFC] lro: Kconfig and Makefile

From: Kok, Auke
Date: Mon Jul 30 2007 - 13:01:44 EST


Jeff Garzik wrote:
Stephen Hemminger wrote:
Why make this a user selectable option at all? Unless you want
to deal with out of tree drivers (not my problem), it should be hidden
to avoid having to explain an support it.

In this case it's an optional library kernel module. That seems to be a common setup for library modules. We do the same with CONFIG_MII and drivers/net/mii.ko as well.

Originally it was done purely in the Makefile, but that does not account for net drivers in sub-directories (or out of tree as you point out).

speaking of that, shouldn't there be a NETIF_F_LRO ?

Auke
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/