Re: Ok, lets kill the 'PCI hidden behind bridge' message (was: pci=assign-busses)

From: Daniel Hazelton
Date: Mon Jul 30 2007 - 16:16:24 EST


On Monday 30 July 2007 14:35:13 Bernhard Kaindl wrote:
<snip>
> Ok, lets kill the message. As Alois NeÅpor also saw, that's fixed up by
> Yenta, so PCI does not have to warn about it. PCI could still warn about it
> if is_cardbus is 0 in that instance of pci_scan_bridge(), but so far I have
> not seen a report where this would have been the case so I think we can
> spare the kernel of that check (removes ~300 lines of asm) unless debugging
> is done.
>
> History: The whole check was added in the days before we had the fixup
> for this in Yenta and pci=assign-busses was the only way to get CardBus
> cards detected on many (not all) of the machines which give this warning.

The message triggers on systems without Cardbus at all.

> In theory, there could be cases when this warning would be triggered and
> it's not cardbus, then the warning should still apply, but I think this
> should only be the case when working on a completely broken PCI setup,
> but one may have already enabled the debug code in drivers/pci and the
> patched check would then trigger.

I wouldn't say totally broken. The last 5 computers I've owned have had this
message. On only one could it even *remotely* be related to CardBus (my one
year old laptop), and on one of them it does create problems for certain
(NVidia) binary drivers. (and then pci=assign-busses doesn't do jack to clear
the message)

I'm not saying that binary drivers shouldn't be broken - but...
<snip>


DRH

--
Dialup is like pissing through a pipette. Slow and excruciatingly painful.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/