Re: [2.6.23-rc1 REGRESSION] CPU hotplug totally broken on HPCnx6325 (x86_64)
From: Chris Wright
Date: Mon Jul 30 2007 - 22:19:52 EST
* Linus Torvalds (torvalds@xxxxxxxxxxxxxxxxxxxx) wrote:
> On Mon, 30 Jul 2007, Chris Wright wrote:
> > This also fixes paravirt patching which was broken when text_poke()
> > tried to patch the various pv ops in lookup_address.
>
> Hmm. What is "this"? The revert?
Yes, sorry, your revert also fixes paravirt patching.
> That said, I do wonder whether virtualization still has problems with
> CONFIG_RODATA, though. We limit the RODATA memory ranges based on KPROBES
> and HOTPLUG_CPU, but not based on VIRTUALIZATION.
>
> I'd expect any virtualization fixups to hit the same problems that the SMP
> alternatives hit. No?
Hmm, patching should've already happened, and aside of module loading,
isn't typically done again. I think it's OK as it is.
thanks,
-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/