Re: [PATCH 4/7] sysfs: simplify sysfs_remove_dir()

[Tejun Heo]

Cornelia Huck wrote:
> On Tue, 31 Jul 2007 19:15:08 +0900,
> Tejun Heo <htejun@xxxxxxxxx> wrote:
> 
>> With the shadow directories gone, sysfs_remove_dir() can be simplified.
>>
>> * parent doesn't need to be grabbed separately.  Just access
>>   old_dentry->d_parent.
>>
>> * parent sd can never change.  Remove code to move under the new
>>   parent.
>>
>> * Massage comments a bit.
>>
>> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
>> ---
>>  fs/sysfs/dir.c |   26 ++++----------------------
>>  1 files changed, 4 insertions(+), 22 deletions(-)
>>
> It's not sysfs_remove_dir(), but sysfs_rename_dir() :) Otherwise this
> looks good.

Yeah, what was I thinking.  :-)

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/