Re: [PATCH 55] drivers/char/n_hdlc.c: kmalloc + memset conversionto kzalloc

From: Alan Cox
Date: Tue Jul 31 2007 - 20:10:10 EST


On Tue, 31 Jul 2007 23:27:30 +0200
Mariusz Kozlowski <m.kozlowski@xxxxxxxxxx> wrote:

> Signed-off-by: Mariusz Kozlowski <m.kozlowski@xxxxxxxxxx>

NAK

> - struct n_hdlc *n_hdlc = kmalloc(sizeof(*n_hdlc), GFP_KERNEL);
> -
> + struct n_hdlc *n_hdlc;
> +
> + n_hdlc = kzalloc(sizeof(*n_hdlc), GFP_KERNEL);

Change looks fine but please keep the original formatting style
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/