Re: [PATCH] Apply memory policies to top two highest zones whenhighest zone is ZONE_MOVABLE

[Christoph Lameter]

On Thu, 2 Aug 2007, Mel Gorman wrote:

> +#ifdef CONFIG_NUMA
> +/*
> + * Only custom zonelists like MPOL_BIND need to be filtered as part of
> + * policies. As described in the comment for struct zonelist_cache, these
> + * zonelists will not have a zlcache so zlcache_ptr will not be set. Use
> + * that to determine if the zonelists needs to be filtered or not.
> + */
> +static inline int alloc_should_filter_zonelist(struct zonelist *zonelist)
> +{
> +	return !zonelist->zlcache_ptr;
> +}

I guess Paul needs to have a look at this one.

Otherwise

Acked-by: Christoph Lameter <clameter@xxxxxxx>

> @@ -1166,6 +1167,18 @@ zonelist_scan:
>  	z = zonelist->zones;
>  
>  	do {
> +		/*
> +		 * In NUMA, this could be a policy zonelist which contains
> +		 * zones that may not be allowed by the current gfp_mask.
> +		 * Check the zone is allowed by the current flags
> +		 */
> +		if (unlikely(alloc_should_filter_zonelist(zonelist))) {
> +			if (highest_zoneidx == -1)
> +				highest_zoneidx = gfp_zone(gfp_mask);
> +			if (zone_idx(*z) > highest_zoneidx)
> +				continue;
> +		}
> +
>  		if (NUMA_BUILD && zlc_active &&

Hotpath. Sigh.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/