Re: [PATCH] USB: Only enable autosuspend by default on certaindevice classes

[Greg KH]

On Fri, Aug 03, 2007 at 12:56:13AM +0100, Matthew Garrett wrote:
> We're seeing a large number of problems with devices not appreciating 
> USB autosuspend, especially printers and scanners. According to 
> http://www.microsoft.com/whdc/system/bus/USB/USBFAQ_intro.mspx only a 
> subset of drivers support it in Windows XP, meaning that most devices 
> are probably untested in this situation. This patch alters the behaviour 
> to match that of Windows. Userspace can still whitelist devices as 
> appropriate, and the set of classes supporting autosuspend probably 
> covers pretty much every driver likely to be found on any portable 
> device.
> 
> Signed-off-by: Matthew Garrett <mjg59@xxxxxxxxxxxxx>

Well, if you do this, then you can pretty much delete the whole quirk
table we have, right?

And personally, I want to do better than Windows XP when it comes to
power management.  This patch is only going to suspend a very tiny
subset of devices, including a whole bunch of ones that do not even have
drivers in Linux, causing our power footprint to be bigger than needed.

Also, we have udev rules for SANE that disables their autosuspend
settings, which handles the majority of the devices we have seen with
problems.

So I really don't want to accept this patch.  But, what problems are you
seeing with our current suspend logic that you feel we need to be this
harsh?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/