Re: [2/3] 2.6.23-rc1: known regressions v3

[Len Brown]

On Tuesday 31 July 2007 00:07, Alexey Starikovskiy wrote:
> Meelis Roos wrote:
> >>> Subject         : New ACPI error/warning with Linus' latest GIT
> >>> References      : http://lkml.org/lkml/2007/7/26/395
> >>> Last known good : ?
> >>> Submitter       : Ismail Dönmez <ismail@xxxxxxxxxxxxx>
> >>> Caused-By       : ?
> >>> Handled-By      : ?
> >>> Status          : unknown
> >> This started to happen after the second ACPI merge which was for 2.6.23-rc2.
> > 
> > It appeared after new Embedded Controller code was merged into ACPI. It 
> > might as well be just a debug message or a remainder to add support for 
> > new queries (whatever these are), but I do not know. The message itself 
> > seems harmless.
> > 
> This _is_ a debug message. EC asks us to perform query which was never defined in DSDT.
> Previously I thought it would be rare error report, but now it seems that every machine
> has at least one unregistered query... It is not a functional regression, as we just 
> ignored errors from query execution before.
> 
> Len already has a patch to remove this printk.

yes, this verbose message has been removed.

thanks,
-Len

commit f1cd1fe61b96e4312312d42c0a9784dfab12e007
Author: Alexey Starikovskiy <astarikovskiy@xxxxxxx>
Date:   Fri Aug 3 17:28:17 2007 -0400

    ACPI: EC: Remove noisy debug printk fron EC driver.
    
    ACPI: EC: Handler for query 0x57 is not found!
    
    Signed-off-by: Alexey Starikovskiy <astarikovskiy@xxxxxxx>
    Signed-off-by: Len Brown <len.brown@xxxxxxxxx>

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 469f3f5..dd384ec 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -471,7 +471,6 @@ static void acpi_ec_gpe_query(void *ec_cxt)
 		}
 	}
 	mutex_unlock(&ec->lock);
-	printk(KERN_ERR PREFIX "Handler for query 0x%x is not found!\n", value);
 }
 
 static u32 acpi_ec_gpe_handler(void *data)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/