[PATCH] Off-by-one in /sys/module/*/refcnt

[Alexey Dobriyan]

Hell knows when this changed, but sysfs is lying about modules refcounts now.

$ cat /sys/module/it87/refcnt
4294967295
$ lsmod | grep ^it87
it87                   15756  0

Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
---

 kernel/module.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/kernel/module.c
+++ b/kernel/module.c
@@ -785,7 +785,7 @@ static ssize_t show_refcnt(struct module_attribute *mattr,
 			   struct module *mod, char *buffer)
 {
 	/* sysfs holds a reference */
-	return sprintf(buffer, "%u\n", module_refcount(mod)-1);
+	return sprintf(buffer, "%u\n", module_refcount(mod));
 }
 
 static struct module_attribute refcnt = {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/