Re: Kernel Bug in 2.4.35 when compiled gcc>=4.2.0 and -march=c3

[H. Peter Anvin]

Willy Tarreau wrote:
> 
> Just to enlighten me on the subject, could you please explain me
> what is wrong in the code ? Granted I found it awful, but even on
> the GCC-4.2 page where -fno-toplevel-reorder is explained, it is
> said that asm statements can be instantiated between functions
> blocks, which is exactly what is used here.
> 

A stray semicolon:

__attribute__((regparm(0))) void call_do_IRQ(void); __asm__(...

... is actually a prototype followed by a top-level asm statement
(because of the semicolon), *not* a function with a single-statement
body (which is itself uglier than hell, use braces please...)

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/