Re: Serial buffer memory leak

[Frederik Deweerdt]

On Wed, Aug 08, 2007 at 02:45:32PM +0100, Alan Cox wrote:
> > I'm not familiar enough with the tty code to decide what the proper fix should 
> > be. I'll try to write a patch if someone could point me in the right 
> > direction.
> 
> Something like this perhaps ?
> 
[....]
> - *	flush all the buffers containing receive data
> + *	flush all the buffers containing receive data. Caller must
> + *	hold the buffer lock and must have ensured no parallel flush to
> + *	ldisc is running.
>   *
>   *	Locking: none
                 ^^^^
>   */
Isn't the comment a bit misleading here? The caller must hold tty->buf.lock.

Frederik
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/