Re: [RFC 08/10] Pass no NULL vfs_lookup to vfs_create

From: Christoph Hellwig
Date: Wed Aug 08 2007 - 15:36:50 EST


On Wed, Aug 08, 2007 at 07:16:30PM +0200, Andreas Gruenbacher wrote:
> Never pass a NULL vfs_lookup to vfs_create() or iop->create by creating
> temporary vfs_lookup objects where needed. Remove the obsolete NULL
> checks.

ipc/mqueue.c should be rewritten to use vfs_path_lookup instead.

nfsd is special - people need to deal with the !nameidata or !intent
case anyway because the fs/exportfs/expfs.c code uses lookup_one_len
all over when the filesystem is mared nfs exportable, but fortunately
the filesystem that are nfs exportable are usually not those using
intents. We might eventually fix this one day by having some kind
open by handle intent, but that should come as part of a large
patch series where we qualify the type of lookup for every single
lookup.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/