Re: [PATCH] Re: cciss: warning: right shift count >= width of type

[Al Viro]

On Sun, Aug 12, 2007 at 03:21:57AM +0200, Rene Herman wrote:
> @@ -2609,13 +2609,13 @@ static void do_cciss_request(request_queue_t *q)
>  		} else {
>  			c->Request.CDBLen = 16;
>  			c->Request.CDB[1]= 0;
> -			c->Request.CDB[2]= (start_blk >> 56) & 0xff;	//MSB
> -			c->Request.CDB[3]= (start_blk >> 48) & 0xff;
> -			c->Request.CDB[4]= (start_blk >> 40) & 0xff;
> -			c->Request.CDB[5]= (start_blk >> 32) & 0xff;
> -			c->Request.CDB[6]= (start_blk >> 24) & 0xff;
> -			c->Request.CDB[7]= (start_blk >> 16) & 0xff;
> -			c->Request.CDB[8]= (start_blk >>  8) & 0xff;
> +			c->Request.CDB[2]= ((u64)start_blk >> 56) & 0xff;	//MSB
> +			c->Request.CDB[3]= ((u64)start_blk >> 48) & 0xff;
> +			c->Request.CDB[4]= ((u64)start_blk >> 40) & 0xff;
> +			c->Request.CDB[5]= ((u64)start_blk >> 32) & 0xff;
> +			c->Request.CDB[6]= ((u64)start_blk >> 24) & 0xff;
> +			c->Request.CDB[7]= ((u64)start_blk >> 16) & 0xff;
> +			c->Request.CDB[8]= ((u64)start_blk >>  8) & 0xff;

	put_unaligned(cpu_to_be64(start_blk), &c->Request.CDB[2]);

which is what's happening here anyway.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/