Re: [PATCH] kconfig: update kconfig-language text

[Randy Dunlap]

Robert P. J. Day wrote:
> On Mon, 13 Aug 2007, Adrian Bunk wrote:
>
> > On Mon, Aug 13, 2007 at 11:38:09AM -0700, Randy Dunlap wrote:
> > > From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> > >
> > > Add kconfig-language docs for mainmenu, def_bool[ean],
> > > and def_tristate.
> > >
> > > Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> > > Signed-off-by: Vincent Legoll <vincent.legoll@xxxxxxxxx>
> > > ---
> > >  Documentation/kbuild/kconfig-language.txt |   12 ++++++++++++
> > >  1 file changed, 12 insertions(+)
> > >
> > > --- linux-2.6.23-rc3.orig/Documentation/kbuild/kconfig-language.txt
> > > +++ linux-2.6.23-rc3/Documentation/kbuild/kconfig-language.txt
> > > @@ -77,6 +77,11 @@ applicable everywhere (see syntax).
> > >    Optionally, dependencies only for this default value can be added with
> > >    "if".
> > >
> > > +- type definition + default value:
> > > +	"def_bool"/"def_boolean"/"def_tristate" <expr> ["if" <expr>]
> > > ...
> > Should the redundant and unused def_boolean be documented or removed?
> >
> > I'd prefer the latter.
>
> me too.  and, as i've suggested before, it would also be cleaner to
> remove the redundant "requires" and almost redundant "depends" from
> Kconfig files, and standardize exclusively on "depends on".
>
> at the moment, there are only five Kconfig files that use the far less
> common "depends" directive:
>
> ./drivers/telephony/Kconfig:    depends ISA || PCI
> ./drivers/leds/Kconfig: depends LEDS_CLASS && ARCH_H1940
> ./drivers/input/misc/Kconfig:   depends EXPERIMENTAL
> ./arch/blackfin/Kconfig:        depends BFIN_DMA_5XX
> ./arch/powerpc/platforms/Kconfig:       depends PPC_IBM_CELL_BLADE
>
> adjust those and there's no reason to hang on to "depends" any longer.
>
> rday

but what problem are these?  what is solved by these changes?

--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/