Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPIcontroller.

[Jeff Garzik]

Mike Frysinger wrote:
> On 8/16/07, Jeff Garzik <jeff@xxxxxxxxxx> wrote:
> > Mike Frysinger wrote:
> > > On 8/16/07, Jeff Garzik <jeff@xxxxxxxxxx> wrote:
> > > > Sonic Zhang wrote:
> > > > > +static void bfin_set_piomode(struct ata_port *ap, struct ata_device *adev)
> > > > > +{
> > > > > +     int mode = adev->pio_mode - XFER_PIO_0;
> > > > > +     unsigned long base = (unsigned long)ap->ioaddr.ctl_addr;
> > > > (added Bryan Wu to CC)
> > > >
> > > > Someone needs to need fix the bfin architecture:  the addresses on the
> > > > bfin_read/bfin_write functions should be 'void __iomem *' not unsigned long.
> > > there are no address pointers anymore, so there is nothing to cast ...
> > > the bfin_read/bfin_write macros are done in sexy asm:
> > > #define bfin_write8(addr,val) __asm__ __volatile__("b[%0] = %1;" ::
> > > "a"(addr), "d"(val))
> > > or i'm misunderstanding what you mean ...
> > >
> > > where do you see (unsigned long) ?
> > Look up (into the message you quoted).
>
> yes, you quoted the driver, not the Blackfin core parts
>
> > Regardless of the implementation, the C type system should be employed
> > to ensure that 'addr' is known to the compiler as 'void __iomem *'
> > rather than unsigned long.
>
> i agree the specific pata driver should be declared the way you
> described, however i dont see how that has bearing on the
> bfin_read/bfin_write macros as you seemed to indicate

Macros completely ignore the C type system.  Look at other architectures 
if you cannot figure out how to implement a static inline with stronger 
typing.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/