Re: [PATCH] ACPI: boot correctly with "nosmp" or "maxcpus=0"

[Len Brown]

On Thursday 16 August 2007 15:36, Andi Kleen wrote:
> > @@ -157,10 +162,13 @@ early_param("nosmp", nosmp);
> >  static int __init maxcpus(char *str)
> >  {
> >  	get_option(&str, &max_cpus);
> > -	return 1;
> > +	if (max_cpus == 0)
> > +		disable_ioapic_setup();
> 
> I must say I never liked that maxcpus=0 ... does disable the APIC
> too. There can be situations where you want only a single CPU,
> but still full APICs because modern systems don't boot without. 

maxcpus=1 will give you that.
new kernel-parameters.txt in patch should say this
(matching what comment in the code says)

> It's the old traditional documented semantics though,
> but on the other hand if it never worked with ACPI i guess people are
> not relying on it.
> 
> So perhaps it would be better to change that? 
> Or add a new option to limit CPUs without disabling ACPIC?

If we cared not for tradition, I'd delete "nosmp",
maxcpus=0 would be a synonym for maxcpus=1
and if you didn't want an IOAPIC, you'd use "noapic"
(heh, don't get me started on the noapic vs. nolapic legacy:-)

The only reason I fixed it instead of changing it per above
is because people may be used to it in non ACPI configurations
and get surprised when it doesn't do exactly the same
thing (or in this case doesn't boot at all) in an ACPI configuration.

Either way is fine with me, but I can't leave it as
"nosmp" and "maxcpus=0" not booting at all on ACPI boxes.

thanks,
-Len
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/