Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

[Kay Sievers]

On 8/17/07, Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote:
> On Fri, 17 Aug 2007 09:02:00 -0700, David Brownell <david-b@xxxxxxxxxxx> wrote:
> > Because for some reason the driver name isn't rtc-ds1742 ...
> >
> > My preferred style for such patches puts the MODULE_ALIAS up
> > near the strange driver name, so it's more clear what's going
> > on.  Putting all the MODULE_*() stuff at the end of the file
> > gets confusing in this case.
>
> OK, then I should update my patches anyway ;)
>
> Which do you prefer, MODULE_ALIAS or change some strings?
>
> I guess there are some out-of-tree users of this driver, but fixing
> them is really trivial, so I don't think this is a big compatibility
> problem.

Again, the only sane solution is to provide MODALIAS="platform:<name>"
from the platform bus, and adding the aliases to drivers who support
autoloading. Modalias strings are not free-text strings, they are
required to be prefixed by the subsystem.

I still fail to see why platform must be different from everything
else in the kernel. Please change that stuff, and the bugs which we
are fighting magically go away, because module-init-tools alias
resolving works like it does for every other subsystem in the kernel.

Thanks for considering,
Kay
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/