Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

[David Brownell]

On Friday 17 August 2007, Kay Sievers wrote:
> 
> > I'm not the one who's advocating a change here.  If you want to
> > first change/break and then fix things, all of that is up to you.
> 
> I'm happy to do that. Patch is attached.

NAK.  That wasn't even a serious attempt at the "fix" part,
though it does the "break" part well enough to cause severe
regressions.

(As well as leaving all my technical points about your pushback
un-addressed.  As I noted before, the evident fact that you don't
have technical responses to them says to me that your pushback
has no real technical basis ...)


Out of around 300 platform drivers in the tree (and many more
not yet merged upstream), this makes it so that only *THREE* of
them can hotplug ... versus in the current tree, essentially
everything that's not a legacy driver is hotplugging just fine.

That's one heck of a regression.  Just shy of 100% ...

Plus it treats rtc-ds1742 as if it's a platform_driver not
an i2c_driver.

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/