[PATCH 2/5] Fix Off-by-one in /sys/module/*/refcnt
From: Greg Kroah-Hartman
Date: Wed Aug 22 2007 - 18:22:31 EST
From: Alexey Dobriyan <adobriyan@xxxxxxxxx>
sysfs internals were changed to not pin module in question.
Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
Acked-by: Kay Sievers <kay.sievers@xxxxxxxx>
Acked-by: Tejun Heo <htejun@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
---
kernel/module.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/kernel/module.c b/kernel/module.c
index 33c04ad..db0ead0 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -784,8 +784,7 @@ EXPORT_SYMBOL_GPL(symbol_put_addr);
static ssize_t show_refcnt(struct module_attribute *mattr,
struct module *mod, char *buffer)
{
- /* sysfs holds a reference */
- return sprintf(buffer, "%u\n", module_refcount(mod)-1);
+ return sprintf(buffer, "%u\n", module_refcount(mod));
}
static struct module_attribute refcnt = {
--
1.5.3.rc5
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/