Re: sata & scsi suggestion for make menuconfig

[Al Boldi]

Al Boldi wrote:
> Alan Cox wrote:
> > > I once sent a patch to make libata a submenu of scsi.
> >
> > Which is wrong
> >
> > Nakked-by: Alan Cox <alan@xxxxxxxxxx>
> >
> > The general comments about moving this stuff around and making it
> > clearer what sd/sr etc are nowdays are good but hiding libata under SCSI
> > will cause even more confusion than it cures
>
> That's easy to fix:  just change the SCSI heading to include a libata
> hint.
>
> Something like this:
>
> [PATCH] libata Kconfig: Allow libata to be selected from within the SCSI
> submenu
>
> Move libata Kconfig sourcing from the drivers Kconfig into the SCSI
> Kconfig, and change the SCSI menu heading to indicate libata submenu
> inclusion.
>
> This allows the user to quickly select additional disk/tape/cdrom support
> from within the same menu.
>
> Signed-off-by: Al Boldi <a1426z@xxxxxxxxx>
> Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
> ---
> --- a/drivers/Kconfig   2007-05-02 17:25:30.000000000 +0300
> +++ b/drivers/Kconfig   2007-08-01 06:33:13.000000000 +0300
> @@ -22,8 +22,6 @@ source "drivers/ide/Kconfig"
>
>  source "drivers/scsi/Kconfig"
>
> -source "drivers/ata/Kconfig"
> -
>  source "drivers/cdrom/Kconfig"
>
>  source "drivers/md/Kconfig"
> --- a/drivers/scsi/Kconfig      2007-07-09 06:38:37.000000000 +0300
> +++ b/drivers/scsi/Kconfig      2007-08-01 06:46:42.000000000 +0300
> @@ -7,6 +7,8 @@ config RAID_ATTRS
>         ---help---
>           Provides RAID
>
> +source "drivers/ata/Kconfig"
> +
>  config SCSI
> -       tristate "SCSI device support"
> +       tristate "SCSI and Libata device support"
>         depends on BLOCK

Actually, this should have read:

--- a/drivers/scsi/Kconfig	2007-07-09 06:38:37.000000000 +0300
+++ a/drivers/scsi/Kconfig	2007-09-09 06:48:11.000000000 +0300
@@ -1,4 +1,4 @@
-menu "SCSI device support"
+menu "SCSI and Libata (SATA/PATA/new IDE) device support"
 
 config RAID_ATTRS
        tristate "RAID Transport Class"
@@ -7,6 +7,8 @@ config RAID_ATTRS
        ---help---
          Provides RAID
 
+source "drivers/ata/Kconfig"
+
 config SCSI
        tristate "SCSI device support"
        depends on BLOCK


I would think that with this minimal change it would make it crystal clear, 
to anybody who can read, where to enable libata support, and at the same 
time not to forget/overlook sd/sr selection.


Thanks!

--
Al

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/