Re: [-mm patch] unexport sys_{open,read}

[Adrian Bunk]

On Sun, Sep 09, 2007 at 02:59:40PM -0700, Andrew Morton wrote:
> On Sun, 9 Sep 2007 21:39:20 +0100 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> 
> > On Sun, Sep 09, 2007 at 10:25:28PM +0200, Adrian Bunk wrote:
> > > sys_{open,read} can finally be unexported.
> > 
> > Andrew, can you please put this in?  Having these exports for syscalls around
> > hsa been a long-time annoyance that can finally be fixed now.
> 
> Sure.  But I think it is better to give people some warning when we're
> planning on breaking out-of-tree things.  I do occasionally receive reports
> of "hey, the X driver which I get from Y doesn't work any more".  Often
> it's open-source stuff, too.  I see no point in irritating our users more than
> we need to.
> 
> If we're changing an API or removing a function then there's nothing we can
> do, but in the case where we're simply deleting an export, it's exceedingly
> easy for us to EXPORT_UNUSED_SYMBOL (and __deprecated_for_modules?) for a
> few months.
> 
> Adrian knows this, yet he habitually sends zero-warning export-removal
> patches and I habitually ignore them.  I guess we must both enjoy this or
> something.

You might rename EXPORT_UNUSED_SYMBOL to EXPORT_UNUSED_SYMBOL_ADRIAN 
because AFAIK I am still the only person who was ever dumb enough to
use it after you wanted me to do so...

Everyone else is allowed to always add, remove and change exports
as he likes, but I should go through this special process.

It makes no sense (except for keeping me busy) to treat some patches I 
send special while changes made by other people that break the modules 
API are still allowed.

Andrew, please define API rules, IOW rules for addition, removal and 
changing of exported code, that are valid for *everyone* or go to hell 
with your EXPORT_UNUSED_SYMBOL.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/