Re: [-mm patch] unexport sys_{open,read}

[Adrian Bunk]

On Mon, Sep 10, 2007 at 02:23:24AM -0700, Andrew Morton wrote:
> On Mon, 10 Sep 2007 10:08:08 +0100 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>...
> > > Adrian knows this, yet he habitually sends zero-warning export-removal
> > > patches and I habitually ignore them.  I guess we must both enjoy this or
> > > something.
> > 
> > And I think almost everyone disagrees with you.  We just carry too much
> > crap around because of your subborness in this issue, and it gets really
> > annoying to have some high up on the food chain fighting his longly flight
> > against the other people.
> 
> I would like to see "everyone" explain what we lose by giving developers a
> bit of warning before we break their stuff.
>...

If it is really your intention that "everyone" warns external module 
authors in advance, the interesting part of the process are patches 
like commit 7d12e780e003f93433d49ce78cfedf4b4c52adc5 that break the API 
for virtually every module.

EXPORT_UNUSED_SYMBOL can't handle such API changes, you'll need to add 
other parts to the process. In this case it would most likely require 
adding a new IRQ API plus new APIs in several subsystems where structs 
changed, mantaining both in parallel for some time, and then dropping 
the older ones after some time.

What we lose is a bit of flexibility when changing kernel code plus a 
bit of time when adding replacement APIs and maintaining both in 
parallel.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/