Re: [PATCH 2/3] Maple bus support for the Sega Dreamcast - keyboard support

[Adrian McMenamin]

On 10/09/2007, Dmitry Torokhov <dtor@xxxxxxxxxxxxx> wrote:
> Hi Adrian,
>

Thanks for the comments - will get on with this but....


> > +     for (i = 0; i < NR_SCANCODES; i++)
> > +             kbd->keycode[i] = dc_kbd_keycode[i];
>
> memcpy?
>

I see that other drivers use memcpy - and will happily convert over -
but, out of interest, is there a reasopn why it is superior?

>
> maple_device appears to be fully integrated in sysfs, please add:
>        kbd->dev->dev.parent = &dev->dev;
>

The bus code already correctly ids the parent device (the above code
would appear to assign the device as the device's parent
incidentally). Is it wrong to make that assignment in the central bus
code as opposed to the driver?

Thanks

Adrian
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/