Re: [RESEND 2][PATCH 3/4] modify account_system_time() to updateguest time in cpustat and task_struct

[Randy Dunlap]

On Mon, 10 Sep 2007 16:12:58 +0200 Laurent Vivier wrote:

> [PATCH 3/4] modify account_system_time() to add cputime to cpustat->guest if we
> are running a VCPU. We add this cputime to  cpustat->user instead of
> cpustat->system because this part of KVM code is in fact user code although it
> is executed in the kernel. We duplicate VCPU time between guest and user to
> allow an unmodified "top(1)" to display correct value. A modified "top(1)" is
> able to display good cpu user time and cpu guest time by subtracting cpu guest
> time from cpu user time. Update "gtime" in task_struct accordingly.
> 
> Signed-off-by: Laurent Vivier <Laurent.Vivier@xxxxxxxx>


Hi,
Please use kernel-doc notation here:
(see Documentation/kernel-doc-nano-HOWTO.txt or source file examples
or ask)

easy fix:

 /*
+ * Account guest cpu time to a process.

/**
 * account_guest_time - Account guest cpu time to a process.

+ * @p: the process that the cpu time gets accounted to
+ * @cputime: the cpu time spent in virtual machine since the last update
+ */
+void account_guest_time(struct task_struct *p, cputime_t cputime)
+{

Thanks.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/