Re: [PATCH] dcache: trivial comment fix

[J. Bruce Fields]

On Mon, Sep 10, 2007 at 02:46:32PM -0400, J. Bruce Fields wrote:
>   * This forceful removal will result in ugly /proc output if
>   * somebody holds a file open that got deleted due to a rename.
>   * We could be nicer about the deleted file, and let it show
> - * up under the name it got deleted rather than the name that
> - * deleted it.
> + * up under the name it had before it was deleted rather than
> + * under the original name of the file that was moved on top of it.

By the way, on further examination of the code it doesn't actually do
what's described in the case where the target name is large and the
moved-from name is small.  Instead, it reports random garbage (usually
part of a name left over from some other dentry?) as far as I can tell:

from switch_names():


	if (dname_external(target)) {
                if (dname_external(dentry)) {
			...
                } else {
                        /*
                         * dentry:internal, target:external.  Steal target's
                         * storage and make target internal.
                         */
                        dentry->d_name.name = target->d_name.name;
                        target->d_name.name = target->d_iname;

... but target->d_iname could have anything in it, right?

--b.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/