Re: [PATCH 1/2] Maple Bus support for SEGA Dreamcast

From: Mike Frysinger
Date: Mon Sep 10 2007 - 19:29:00 EST


On Monday 10 September 2007, Adrian McMenamin wrote:
> +config MAPLE
> + tristate "Maple Bus Support"
> + depends on SH_DREAMCAST
> + help
> + The Maple Bus is SEGA's serial communication bus for peripherals
> + on the Dreamcast. Without this bus support you won't be able to
> + get your Dreamcast keyboard etc to work, so most users
> + probably want to say 'Y' here, unless you are only using the
> + Dreamcast with a serial line terminal or a remote network
> + connection.

hmm, tristate means you can build it as a module ... so please add a line that
says what the module name is if 'M' is selected ...

> --- a/drivers/sh/Makefile
> +++ b/drivers/sh/Makefile
> +obj-$(CONFIG_MAPLE) += maple/

ok ...

> --- /dev/null
> +++ b/drivers/sh/maple/Makefile
> +obj-y := maplebus.o

erp, shouldnt that be obj-$(CONFIG_MAPLE) ?
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.