Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page

[Herbert Xu]

On Mon, Sep 10, 2007 at 09:46:46PM +0200, Ingo Oeser wrote:
>
> What about using max() for this to make your intention obvious?
> 
> static inline u8 *blkcipher_get_spot(u8 *start, unsigned int len)
> {
> 	u8 *end_page = (u8 *)(((unsigned long)(start + len - 1)) & PAGE_MASK); 
> 	return max(start, end_page);
> }

Yes that looks sane.  Could you please send a patch?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/