Re: [PATCH] v3 of IBM power meter driver

[Jean Delvare]

On 9/11/2007, "Mark M. Hoffman" <mhoffman@xxxxxxxxxxxxx> wrote:
>* Darrick J. Wong <djwong@xxxxxxxxxx> [2007-08-28 16:25:05 -0700]:
>> --- a/drivers/hwmon/Kconfig
>> +++ b/drivers/hwmon/Kconfig
>> @@ -275,6 +275,18 @@ config SENSORS_CORETEMP
>>  	  sensor inside your CPU. Supported all are all known variants
>>  	  of Intel Core family.
>>
>> +config SENSORS_IBMPEX
>> +	tristate "IBM PowerExecutive temperature/power sensors"
>> +	depends on IPMI_SI
>
> Open question: can we use "select" here?  As written, it took some hunting
> to even get this driver to show up as an option in menuconfig.

My 2 cents: I assume that people who have IPMI-capable hardware are aware
that they do. Thus, if you change the above to "select IPMI_SI", you
probably want to add "depends on IPMI_HANDLER" (not sure why it's not
just named CONFIG_IPMI).

--
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/