Re: build #286 failed for 2.6.23-rc6-g0d4cbb5 inlinux/arch/i386/mach-voyager/setup.c

[James Bottomley]

On Tue, 2007-09-11 at 16:21 +0200, Toralf FÃrster wrote:
> Hello,
> 
> the build with the attached .config failed, make ends with:
> ...
>   CC      arch/i386/mm/highmem.o
>   LD      arch/i386/mm/built-in.o
>   CC      arch/i386/mach-voyager/setup.o
> arch/i386/mach-voyager/setup.c: In function 'time_init_hook':
> arch/i386/mach-voyager/setup.c:52: error: implicit declaration of function 'safe_smp_processor_id'

This should be a warning, not an error

> make[1]: *** [arch/i386/mach-voyager/setup.o] Error 1
> make: *** [arch/i386/mach-voyager] Error 2

> The build was made with an old .config from kernel 2.6.22-rc3
> (where the build also failed) :
> $> make mrproper && cp <oldconfig> .config && make oldconfig && make
> 
> Here's the config:
[...]
> # CONFIG_SMP is not set

This is the problem ... it's a known one on voyager.  This will prevent
the config being selected by the random config generator.

James

diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
index 97b64d7..cca3b90 100644
--- a/arch/i386/Kconfig
+++ b/arch/i386/Kconfig
@@ -146,6 +146,7 @@ config X86_ELAN
 
 config X86_VOYAGER
 	bool "Voyager (NCR)"
+	select SMP if !BROKEN
 	help
 	  Voyager is an MCA-based 32-way capable SMP architecture proprietary
 	  to NCR Corp.  Machine classes 345x/35xx/4100/51xx are Voyager-based.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/