Re: [PATCH] ehca_irq: Misc cpuinit section annotations and #ifdef cleanups

From: Joachim Fenkes
Date: Wed Sep 12 2007 - 11:54:41 EST


On Thursday 23 August 2007 01:28, Satyam Sharma wrote:
>
> * Replace {un}register_cpu_notifier with {un}register_hotcpu_notifier
> thereby losing a couple of #ifdef HOTPLUG_CPU pairs.
> * Move comp_pool_callback_nb declaration to below that of callback
> function so that initialization of .notifier_call and .priority can
> occur at build time itself and not runtime.
> * Mark the notifier_block (and callback function, and another static
> function used by it) as __cpuinit{data} for the sake of consistency
> and remove enclosing #ifdef. (This may increase size for modular
> build of this module, however, because these are no longer dropped
> unconditionally now.)
>
> Signed-off-by: Satyam Sharma <satyam@xxxxxxxxxxxxx>

Looks okay to me.

Acked-by: Joachim Fenkes <fenkes@xxxxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/