Re: [PATCH]PCI:disable resource decode in PCI BAR detection

From: Shaohua Li
Date: Thu Sep 13 2007 - 03:39:41 EST


On Thu, 2007-09-13 at 01:31 -0600, Matthew Wilcox wrote:
> On Thu, Sep 13, 2007 at 02:21:07PM +0800, Shaohua Li wrote:
> > http://bugzilla.kernel.org/show_bug.cgi?id=8833
> > We write 0xffffffff to BARs to detect BAR size, this will change BAR
> > base to 0xfxxxxxx depends on BAR size. In the bug, PCI MCFG base address
> > is 0xf4000000. One PCI device (gfx) has a 256M BAR, the detection code
> > will temprarily change it to 0xf0000000, so conflict with MCFG decode
> > range. Later memory based config space read/write address is decoded by
> > both MCH and gfx and cause a hang. This patch disables resource decode
> > in BAR size detection to avoid resource conflict.
>
> You missed the part where we have to avoid doing this for host bridges ...
>
> http://marc.info/?l=linux-kernel&m=118809338631160&w=2
>
> (I believe it's now queued in Greg's tree, and possibly Andrew's tree
> too)
Hmm, I don't know there is already a fix for this, so waste a whole
morning :(. yes, your patch looks better.

Thanks,
Shaohua
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/