Re: DTR/DSR Patch

[Russell King]

On Wed, Sep 12, 2007 at 05:38:17PM -0700, Andrew Morton wrote:
> On Fri, 31 Aug 2007 15:17:41 +0200
> Michael Westermann <michael@xxxxxxxxxx> wrote:
> 
> > Hello,
> > 
> > I make driver for Point of Sale Printer, a wide range of Printer use
> > only a DTR/DSR hardware-handshaking. When I use a handshaking in the
> > userspace, the Printr has a overrun problem and our customer has a
> > problem with the tax office.
> > 
> > my Patch relaize a simple DTR/DSR handhake with a small change of the
> > code. The change auf the userspace is very simple. e.g.
> > 
> > 
> > cflags |= CDTRDSR;
> > 
> > The change of the stty tool at 2 lines.
> > 
> 
> googling for CDTRDSR is useful.  I see from
> http://lkml.org/lkml/2006/12/10/49 that Russell was generally supportive,
> but requested changes which afaict you have implemented here?

Partially implemented - my point 1 seems to have been addressed but not
point 2.  Point 2 is rather important, otherwise you can end up with a
port in stopped mode with no way to get it transmitting.

Also, it doesn't seem to be tweaking the DTR signal at all, so how does
it tell the remote end to stop transmitting?

Essentially, the author needs to search for CRTSCTS in serial_core.c and
*carefully* consider whether they need to modify those places as well.
I stress carefully, because at the moment we start the tty whenever
we move from CRTSCTS to no CRTSCTS.  If you're moving CRTSCTS->CDTRDSR
then you only want to do this iff DSR is asserted.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/